Since a few OS updates back, windows are not re-opened when I log in even though "Reopen windows when logging back in" box is always checked when I log out. I'm running macOS Mojave (10.14.3) and I think this happened immediately following one of the OS updates (maybe in 2017).
It might help to...