It's not a bad buy, but as Willo34 said - the keyboard on the 2016-2018 models were horrendous (as far as breaking) but the typing experience came down to personal preference (some loved it, some hated it).
From a performance standpoint, the current baseline MacBook Air outperforms that years pro for about 300 bucks more brand new with a much better keyboard and is way less noisy with substantially better battery life as well.
When it comes down to it, you did get it for a good price. As long as it does what you need it to do, I'd just hang on to it until it dies out.