OneDrive is solid if it's supported... iCloud is spotty and I wouldn't trust anything on it. Apple has yet to fix the iCloud backup restore sync problem where iMessages and other data do not restore.
My advice which ever you use, do a local backup too... hard drives are pretty cheap.