Almost there...
You've almost got it.
What the warning is actually saying is that you are trying to initialise your NSNumber objects by saying that they are string objects. If you think about it, that doesn't make sense.
NSNumber doesn't have a numberWithString: class method, so you can't use an NSString to initialise it. However, NSString does have a floatValue: method, so you can convert the string to a float, and then use that to initialise the NSNumber. Like this:
Code:
NSNumber *price1 = [NSNumber numberWithFloat:[price.text floatValue]];
NSNumber *dollar1 = [NSNumber numberWithFloat:[dollar.text floatValue]];
If you change your two NSNumber declarations to the above code, the rest of the code you supplied previously should work.
But... note that I have used floats rather than ints. If you're dealing with money, and I'm assuming that you are, you will probably need to use floats to capture cents as well as dollars. You will also need to change the type of string1 to float, and get the floatValues of price1 and dollar1 when you come to do the calculation. This might save you a bit of head-scratching in the future. And I suggest that you start looking through the documentation for ways to format the output to look more like currency values. NSNumber has a method called descriptionWithLocale: that may help you.
And finally, just a little bit of general advice about style: be careful with your variable names. Calling variables price, price1, and so on is OK in a short piece of code, but as you get further into your program, are you going to remember the difference between price8 and price9? I know I wouldn't. And also, you have an integer called string1. When you look back over the code, what type are you going to assume it is? An integer, or a string? I'm certainly not trying to get at you, but it's a good idea to get into good habits as soon as possible. I didn't, and it was painful for a while. But when you're poring over your code in a week's time, thinking, "Why the &%*@ isn't it working
now?", having variables whose names reflect their functions will really help. Take it from one who found out the hard way.
Have fun, now!