Your pic showing the settings looks fine to me. You can keep location services off all the time if you want and set it to “ask” for each app each time it is used. In my opinion, setting the permission to “while using the app” it fine, although some apps have no business using your location to begin with.