In my experience, both the 11" iPad Pro and the Apple Pencil 2 RETAIN their charge just fine once they're charged up. I can charge both up to 100% and then let them sit for days at a time and they barely lose any of their charge at all. It's when I have the Pencil magnetically attached for more than about a day without use that I run into issues. The Apple Pencil starts gradually losing charge and not allowing itself to be topped off, and the iPad Pro is constantly trying to top it off and losing charge. It's a losing battle for the iPad, because for some reason the Pencil doesn't flip over into whatever mode it needs to take the charge. It still shows as connected, but the little lightning bolt charging icon is not there, and it stops allowing itself to accept the charge from the iPad.
For me, simply taking the Pencil off for a few seconds and putting it back on makes it so that the Pencil tops off to 100% and stays there for about a day. But then after that, it starts gradually decreasing again and not taking the charge from the iPad again, while the iPad is trying and trying and trying to top it off. THAT is where the iPad's battery loss is coming from.
I am 100% convinced that this is an Apple Pencil 2 firmware issue, an iOS 12 issue, or a combination of both. It needs to be fixed ASAP. Some have said "Of course this is how it works! The charge dock was not meant to be a storage solution! You should take the Pencil off when it's done charging!" That is BS. The magnetic charge dock is convenient BECAUSE the Pencil is always supposed to be there and ready to go when you need it, unlike the original that had no storage options at all.
I agree this is most likely a software issue. My iPad Pro 12.9” holds a charge just fine. I can get it to 100%, unplug it, and it’ll lose, maybe at most, 1% of its charge as it sits for a few days. My pencil, on the other hand, that loses a fair bit of charge over a few days. I’ve never paid it much mind, but I believe it lost about 15% of its charge over 3-4 days of sitting by itself on my desk. I’ve noticed, by watching Bluetooth connections, that the pencil is motion activated for connections, and sensitive. In my iPad, the pencil will show as not connected, but if I pick it up, it immediately shows as connected on the iPad. So, it’s possible, in my case, bumping the desk, etc. activates my pencil, and it uses some battery power until it hibernates again.
I don’t find either of the above mentioned scenarios concerning. What I do find frustrating is the inability to leave the pencil attached to the iPad, without it crippling my battery storage overnight. To me, part of why Apple designed this new charging method was so one could leave the pencil attached to the pad, so it would be right there, always ready to go, whenever one wanted to use it. Apple even mentions this convenience in their marketing. I do hope this issue is addressed in a not too distant software update.