Launch iTunes on your computer, not on the iPhone, go to the Store menu and select "View My Account." Go to Edit Payment Information and make sure that the expiration date or security code or card number are still valid and then click Done in the lower right. Hopefully doing it from the computer will allow it to correct whatever the iTunes Store thinks is wrong with your account and allow you to avoid having to do that every time.