I like it, overall, but this particular iPhone "X" line of phones (and I would lump the 11 into this since it's the same form factor) have distinct pluses and minuses so be prepared. I knew that going in, but really wanted a better camera and this one was it.
The big pluses are obviously the camera is a massive step up, the screen is so much more detailed and watching movies full screen is EXCELLENT. With the great screen + real stereo separation with the speakers, it's a massive improvement. It also records video in stereo which is cool and the thing gets LOUD if you need it to.
But I find the phone not as "user friendly" as the 6S+ for a lot of reasons. Losing touch id and the home button is a big letdown. While, I knew that going in, whatever "security" Apple claims is BS because I'm punching in my numeric code more than I ever did with touch id.
But besides that, the home button was a really useful feature for switching/exiting apps and the "gestures" are piss poor substitutes in my opinion. Hell even doing the basic hard reset on this thing is a royal PITA with the multiple "volume up/down then hold side button" crap. Only works half the time.
Now maybe you don't use this a lot in your phone workflow so it won't be a big loss and sometimes face id is good for logging into apps so you'll prefer it.
I would absolutely check one out in the store along with the 8 and maybe wait for the SE or see what might be coming with touch id again before making up your mind.