I would say neither. I went XS to 11Pro because I’m a photographer who’s increasing his repertoire in DSLR and digital cameras. I also bought it because of the much improved battery, brightness, new finish, and such. For me it was worth it. The XR is more well-rounded compared to the XS(Max), but it just lacks the OLED and telephoto. Going to the 11 is pretty pointless and spending money on the XS Max is somewhat pointless when you can wait until next year to see what the new options are.
the iPhone 12 could finally transition 6.1 models to OLED. If not, just get the 12 Pro Max upon release or a discounted 11 Pro Max. You have a XR, so there is a lot of leeway with your options, but not necessarily based on the two options you present in your post.