I personally have a hard time recommending spending a lot of money on 3 year old technology. While not perfect, I think the 2018 model is the best approach, if not that, then maybe another maker's computer, i.e., Dell, Razer, MSI, etc.
For graphic designers and other tech professionals, sure, but the vast majority of users will be served just fine by 3 year old tech for the right price. We’ve reached a point of diminishing returns in computer processing power growth relative to cost. Its why Macbook Airs are still champs for most Macbook owners who don’t need the latest chips and GPUs (not to mention the more useful ports of older machines, USB-C has most certainly not caught on yet for most users).
If I upgrade my 2013 Air it will be to a 2015 13” Pro that I have access to which was purchased for $1250 new at the beginning of the year (i5 256gb 16gb ram). If I needed it for heavy video or graphic work I’d choose differently, but not 1/100 users need it for that, Mac forums skew heavily to that demo (or at least armchair “pros”).
If I were suggesting a new Macbook purchase to an average computer using friend today, it would be the touchbarless 2018 13” MB Pro
only once it has been updated with the new processors and more reliable keyboard. Otherwise I would suggest they wait a few months to see what else Apple had up their sleeve. The current machines are overpriced compared to more feature-rich models of years past (ports, keyboard [reliability and travel], battery life, Magsafe, even the lit logo and more reasonably sized trackpad).
I couldn’t in good conscience recommend any Macbook 12” or 2016-2017 MB Pro of any type, knowing the keyboard is unreliable and repairs could cost $700+, and entail a massive hassle even under warranty. Apple breached Macbook buyers trust over the past three years and they are just now taking the steps to rectify it.