I don't know why but I've been flirting with the idea of switching to a Samsung for a while now. I've played with it in stores and I didn't particularly like it I just find that iOS has gotten stale. I currently have a macbook pro, ipad pro, apple watch, airpods, multiple apple tvs, so i'm not sure whether or not it's a good idea to break out of the ecosystem. My iphone does more than everything I need it to do and i've never had a single problem with any iphone i've owned since the 4. I just for some reason want to try out an Android but my brain is telling me it's a terrible idea and that my XS Max is almost paid off. Any thoughts/suggestions?
It's not a terrible idea, but it's going to take some investment. And not just financially like getting a new smart watch, earbuds, fast wireless charger, or other accessories. But an investment in redesigning your own ecosystem, and getting used to the way Android works. Plenty of switchers give up very quickly.
You've already made the first mistake (for lack of better word) in being fully engulfed in Apple's ecosystem.
I would personally suggest, slowly moving to Google services, like syncing contacts, calendar, voicemail (via Google Voice), and etc, while you're still using the iPhone. This will make for an easier transition.
The Pros will be the freedom, features, and compatibility.
The Cons will be the lack of integration with your other Apple devices, and Google nor Samsung is designed to hold you hand.