My wife and I used to share a single iCloud account for the sake of being able to view each others pictures after we had our first child. Over time, Apple has made this method unusable so we now use Google Photos on both our iPhones (signed into a single account). Google Photos has unlimited storage of (downscaled, but fine for viewing on the phone) photos and videos and the phones automatically sync in the background throughout the day.