macOS what's wrong with this shell script?

[wala]

http://osx-e.com/articles/mass_extract_icons.html

The shell scripts listed used to work on my Mac, but they don't any more...
Where did I go wrong?

 

[kainjow]

It worked for me. You made sure that you chmod-ed the file correctly to execute it?

 

[wala]

It worked for me. You made sure that you chmod-ed the file correctly to execute it?

chmod is my best friend! I might as well have done "chmod -r /"... lol. I think it's a problem on my Mac with some temp files or something like that. Sometimes it worked, sometimes it did not... it's working now though. Restarts cure everything