I have iCloud photos enabled, and then I use the ICloud app for Windows 10 to sync copies down to my Windows 10 PC. Only problem is it dumps thousands of images into a single folder in Windows.
I’m a Lightroom user as well, so I can also use Lightroom to sync curated images between the devices.
As an amateur photograph enthusiast and Lightroom user, I still think of my computer hard drive as the primary working location for Lightroom. I upload my most important stuff to my Smugmug site once I have edited and tagged the photos. Increasingly I am just uploading photos and videos from my iPhone to Smugmug directly.
I guess I’m moving ever closer to a cloud based workflow. I agree that Onedrive isn’t the best solution for photos (Google Photos is better IMHO), but you can make Onedrive work for you by syncing it to your desktop.