Become a MacRumors Supporter for $50/year with no ads, ability to filter front page stories, and private forums.
Out of curiosity, have you enabled 'optimize photo storage'? And how many photos/videos do you have?

I used to have lots of trouble with iCloud Photo Library, but it's largely been worked out now. What I found during a year or two of off and on trouble is that no one, even Apple, really know how it works and you wake up one day and it's magically fixed.
 
Register on MacRumors! This sidebar will go away, and you'll see fewer ads.