I have been a hobbyist photographer for awhile now. I got rid of my last DSLR quite a few years ago and just shoot on my iPhone these days. Started out with 160k photos on Google Photos back in the day when you could store photos for free. I kept them on my computer via Google Drive app and backed them up to external drives.
When I moved to iPhone I eventually decided I wanted to use iCloud so I spent some serious time getting rid of duplicates and culling my photos - got it down to 40k (yes, there were a LOT of duplicates - this took several years).
Now?
I have my entire library in iCloud Photos 54,664 photos and 1,593 videos. I do use Google Photos as a secondary backup mostly because I have family/friends with Google who like to share albums/photos - extremely convenient and a good backup. iCloud Photos on my Mac is set to download all as well. My iPhone is also set to download all originals.
View attachment 2133550
On my iPad I have optimized photo storage turned on (it barely uses 10GB).
Using iCloud as my primary photo storage has been extremely convenient. I take a photo anywhere and it's instantly available on all my devices. Pretty happy with this setup.