I would get the XR over the 8, XS, and XS Max (in fact, that is what I intend to do), but color has nothing to do with my choice.
I've weighed upgrading my 6s to the 8, 8 Plus, both XS's, and XR. I've really wanted more screen than my 6s, and I don't think an 8 will make my user experience that much better. I love the LCD screen of the Plus-sized phones--they're ever so slightly but nicely more crisp than the 326 ppi displays. Still, the overall size of those phones are larger than I want to carry.
The XS isn't really as large as I want, though it's better than my 4.7" 6s, but, honestly, the price of the XS and the XS Max are simply beyond what I'm willing to pay. I can afford it (mortgage is paid off, no debt whatsoever), but I simply cannot justify it for me.
So that leaves me with the XR. Sure, I would prefer the nicer OLED screen, but not for hundreds of U.S. dollars more. A 128GB XR comes the closest to hitting the sweet spot for me. The screen will be fine, it should have a really good camera, and it has the same A12 chip as the XS and XS Max.
For me, it's a matter of value. I can justify $799 for a 128GB XR and, I think, be completely happy with it. To get the next step above the 64GB XS pushes you to the 256GB and a cost of $1149, not to mention sales tax. And the comparable XS Max is $1249. For those who buy the XS and the Max, more power to them. They are great phones.
So 8 versus XR" For me, it's an easy call--the XR over not only the 8 but also the 8 Plus, XS, and XS Max, but there's a reason different flavors of ice cream are for sale.