They just released new MacBook Pros recently. I sincerely doubt they will introduce new MacBook Pros in the Fall.
"Now" is always the best time to buy any new MacBook. The hardware changes are incremental (heck, the 13" 2019 model uses the exact same generation of CPU as the 2018 model and the only difference comes down to keyboard materials) and you do not lose out much these days, unlike the "transitional period" of 2013-2014-2015-2016 where Intel was adding features after features after features to their CPU lineups and Apple was prepping to abandon nVidia GPUs.
As for keyboard problems, they will happen. I just replaced the keyboard in my work-issued 15" 2018 model. Will the 2019 model be better? Sincerely, after owning four generations of the butterfly keys, I'd have to say: nope. I think the design itself is flawed. New materials won't help when you get debris stuck in between the key and metal casing. Nothing will be able to push that out, and the key will get stuck all the same. I've had it happen so I know. Apple needs to design less brittle key mechanism and I doubt that's going to happen any time soon.
I have also had the chance to play around with some Windows laptops recently, so... here's my breakdown in case it interests anyone:
MacBook Pro:
Pros:
1. Thin, light, very sturdy casing. Not built like tanks but doesn't feel cheap either.
2. Screens are top-notch. Resolution may be low-ish (not 4K) but I sincerely couldn't tell the difference. Color reproduction is far more accurate on MacBooks.
3. Quiet and doesn't get too hot for certain workloads (for me, I write codes, compose Office docs, surf the web, and watch Youtube, occasionally fixing up photos and such). Short-burst performance is excellent.
4. Trackpad is still best in class, nothing ever comes close
5. Managing multiple windows/desktops/workspaces is still by far the best
6. Warranty is probably still top notch in the market. Took them 3 days from my store visit to return my repaired MacBook, complete with new keyboard and screen. And recently, there's AppleCare+...
Cons:
1. 15" can throttle down if GPU is stressed alongside CPU. I can never get both running at their max performance. Thermal seems to be the culprit. Apple needs better, more efficient GPUs from AMD or a redesign of their MacBooks for better thermal management.
2. Display is pretty brittle, it scratches and dents very easily as opposed to the pre-2015 line. AppleCare(+) is highly recommended if you don't plan on selling next year.
3. In the same vein, keyboard is highly volatile and brittle. It breaks very unexpectedly. I have had all generations of the butterfly keys since 2016 so at this point, I just gave up and got AppleCare+. Also I have both a work-issued 15" machine and my own personal 13" so there is no down time for me. (what are the chances both keyboards will break at the same time?)
4. Touch Bar is useless and actually slows down my workflow sometimes. I'd sacrifice cute animals to keyboard Gods for Apple to come out with 15" machines without the Touch Bar and/or update the non-Touch Bar 13" machines with quad-core CPUs.
5. MacOS comes with its own "artificial limitations" with regards to Youtube, like... Google doesn't send h.264 videos beyond 1080P to Safari, and Safari refuses to support VP9, so Safari can't play back Youtube videos at 2.5K or 4K or 8K. Chrome supports 4K playback but it runs only on the CPU (despite there being hardware acceleration) and that causes some funny performance issues. In short: Apple doesn't support VP9 and in turn, Google doesn't want Chrome to fully support Macs. End result: MacBooks suck if you want to watch Youtube beyond 1080P. It doesn't matter for most videos but if you are watching a coding tutorial of someone who recorded their 4K or 5K screen, that can be quite problematic.
Any other random Windows laptop (I've played around with Dell XPS 15 and Huawei Matebook Pro before returning to 13" MBP):
Pros:
1. Decent build quality, feels like tanks
2. Screens are okay. At least they are high resolution and likely supports touch (novelty kinda wears off when you realize you shouldn't touch a full desktop OS).
3. High performance for long sustained load. Can max out both CPU and GPU for a "long" time, or at least until the battery dies about an hour later.
4. Chrome supports everything... from touch to 4K and even 8K Youtube videos. Novelty wears off when you realize not everything is available in 4K but... for the stuffs that are, it's glorious.
5. Better keyboard than anything Apple has put out for the past... 4 years.
6. Windows 10 finally gets to the point where the hourglass (waiting/loading cursor) almost never shows up anymore.
7. Ubuntu inside Windows 10, so there's not much of a need for VMWare. Though... there's Docker now so the need for a VM has diminished greatly.
Cons:
0. Not minor, and warrants a "zero" point: I cannot open the lid of these things with one hand, gotta hold the bottom down with the other hand.
1. Loud. Very very loud. As in... if I'm compiling my code, then the whole department will look on as if I'm trying to launch a space rocket. It's actually quite disruptive at work. I wouldn't doubt it if you tell me they put mini vacuums inside these machines.
2. Battery life sux. Despite reviews claiming 10 hours+ screen on time and condemning Apple for "only" 8 hours of battery life in the new MacBook, I honestly could never get beyond HALF (5 hours) what most review sites are getting for these Windows laptops.
3. Touch screen is okay but kinda tiring (gotta reach for the screen) and pointless for most desktop pro apps, and especially for coding. Trackpad just sucks and honestly, should not even be included (considering the machine has a touch screen) if it was going to suck so much.
4. The way Windows 10 handles multiple windows and desktops is... well, I'll be nice: it's "almost" as good as Leopard/Snow Leopard, which is now... "only" over a decade old. At least they're trying.
5. Support for HiDPI displays is still kinda... work in progress. It works faster than Apple's method but not all apps support it and it's pretty obvious that developers can't be arsed to fix their apps, even when it's an app that's constantly being updated. I get that the underlying code is more important, but when the UI is next to impossible to read on a 4K 15" screen...
6. Built like tank but kinda heavy/hefty compared to an equivalent MacBook. Not a major down point but it kinda highlights how "well-designed" MacBooks are.
7. Pricing-wise, I didn't expect these to be so close to the MacBooks. People talk about the Apple tax but seriously, when you look at the mid-end market for these Windows laptops now, they aren't cheap at all. Ultimately, I didn't think I was saving money by going with a Windows laptop. It was mostly a matter of choice. And if I have to choose, MacOS will win (and it did) as a software development environment.
So that's my breakdown after some adventures with Windows computers. Back to the Mac I went, but maybe you'll choose otherwise. I certainly can tell why someone would prefer certain Windows laptops over MacBooks. But for me, MacOS is good enough a reason to stick with a MacBook.