Apple's opposition to right to repair is a well known fact. Whether it constitutes anti-consumer behavior is a matter of interpretation and personal stance. This is a very interesting discussion on its own, but is probably not appropriate in the context of this thread.
What I am trying to say is that Linus's interpretation assume that there is specific malicious intent behind these design decisions. But this is an additional assumption which is not necessary to explain or understand these decisions. If I am giving you a sandwich with butter it's not because I go out of my way to prevent you from putting cottage cheese on it instead. It's just that I want to make a sandwich with butter and speading the butter directly onto the bread is the simplest option for me. It didn't even cross my mind that you might want it with cottage cheese instead and if you tell me about your right of having your bread with whatever you want I will probably just shrug. Can you accuse me of malicious intent in this scenario?
I think you might be overdramatising this a bit. First, how can you know that there will indeed be a stack of useless Macs? Apple has been shipping on-replaceable SSDs since 2012, and it doesn't seem like it has exasperated the e-waste issue. But what's most relevant, do you think that there is indeed a substantial enough amount of users who would continue to use the computer with an external SSD or even replace the failed drive? My experience is very different. The majority would just get a new computer once their SSD goes. Hell, people don't even replace the battery on their iPhones, but get a new one instead!
What you say makes a lot of sense in the context of options. The way how Apple designs these things certainly removes the option of prolonging the lifespan of the machine. And I fully acknowledge that there are users who would prefer to have these options and I respect their opinion. Frankly, I too would prefer if the SSD were replaceable and SSD upgrades were a reality (if not by user than at least by Apple). But I don't think it is correct or appropriate to frame these kinds of wishes in the context of environment or e-waste.
This is certainly part of their business model, yes. But there are also some valid technical reasons not to use M.2 SSDs. Power consumption, protocol optimisation, reliability (no third-party firmware with unclear behavior)... For example, Apple SSDs correctly implement data flush operations, while many consumer SSDs lose data even after confirming that the data has been written. M.2 SSDs have their own RAM for caching, while Apple can use the system RAM, improving power consumption and performance in certain situations. And so on.
Do these advantages outweigh the loss of upgradeability and repairability? That's a different question which probably cannot be answered generally. As I said, I'd prefer if all NAND on Apple Silicon was replaceable and if Apple offered a NAND upgrade/replacement service (either in shop or via their self-repair program).