I'm still using an XS (with 84% battery "health" figure), which won't get any more updates (though I've chosen to stay on 17), so I'm due for a new phone.
The camera is important to me, and I keep my phones, so whatever the cost difference is between Pro and non-Pro is easily worth it, and amortized over a longer period.
I could probably eek out another year, and wait for the 18 cycle and a pinhole notch, but either way, have no need for a folding phone. Had a Plus in the past, and the XS is already as large as I need, or wish to carry around.
Originally bought my XS a few months after launch, just after the new year, and barring any external factors that may affect the price, will probably try to do the same this time. Sales were slow at the time, and Apple bumped the trade-in values. Don't expect that to recur, but we live in volatile times.
And if the speculation about a $50 price hike, but offset by 256GB base config, are true, I'd welcome that, since I was already debating opting for a higher config than the current 128GB baseline. Even if it isn't, I will already have double the storage, minus the space consumed by the AI software payload that I won't use.
But I am scheduled to be overseas after the 17 launches, and will see how the model specs turn out. I expect the ROW models to still retain a SIM slot, but that would be offset by the loss of mmwave and other radio band differences.
I'm a gadget person, and like shiny new things, but well past the point of FOMO. I now place greater value in having a solid, reliable tool, with decent durability and useful life more than any gee-whiz sales points.
The XS has been a great phone for me, and never given any trouble. I expect the same again.