No regrets on buying my 2017 gold 128GB iPad. Upgraded from a 32GB iPad Mini 2 and I'm finding the upgrade to be great. Using it for PDF/document referencing from OneDrive/OneNote, reader with the Kindle app, Apple Music client, YouTube & Audible client in the kitchen and has replaced my 2011 MBP for 90% of what I used to use my MBP for; banking, light productivity (MS Office) as well as the usual web browsing, occasional Netflix/Prime viewer, iMessaging etc.
Still tempted with the 10.5 Pro when it comes time to upgrade my laptop but for the moment, the 2017 iPad is an absolute steal for what it can do. Muti-tasking and split screen work is good now and iOS 11 will only kick it up a gear again. Looking at the trajectories of macOS and iOS, it's clear where Apple thinks the future will be and I'm very much starting to agree with them.
With the desktop upstairs, everything else can be done with greater mobility and power between my iPad and iPhone.