Soli isn't a useful feature for me and I never use always on display so it's not really a sacrifice - if being disabled helps with battery then that's great.
I never had the Pixel 2 but did have the 3 and can agree the battery on that was poor, I struggled to get 3 hours screen on with it, I sold it within a week.
In the beginning I was apprehensive about the small battery on the 4 but decided I would give it a punt(like I do with most phones). To my surprise, for whatever reason, its doing OK for me, not great, but OK.