Had some different milage on MacBooks en powerbooks.
My 2003 G4 powerbook was used (by me) for about 4 or 5 years. When the Intels took over the G4 just was left behind in functionality and speed, it showed its age quickly. Then an early core2 MacBook Pro, which served me well for 2 years before it got stolen. Then I've tried an Air, which was underpowered (CPU and memory) and sold quickly.
in 2010 I bought a MacBook Pro which was a dream to me, had upgradable parts (memory and storage) and served me until 2019, then the second battery died and was left behind with macOS updates (this was by far the best MacBook for me). The 2019 MacBook Pro which followed was the biggest disappointment to me, the Touch Bar was not only useless to me but an actual nuance in my daily usage, with unintended light touches it always interfered and never did anything useful while taking function keys which I actually did use. The security enclave gave headaches in earlier software but those dissolved, and the keyboard being better still not great .. after only 2 years I stoped using it, it's still collecting dust an expensive disappointment
Now on a MacBook Pro m1, apart from a dent in the case of the screen (own fault) it's great, keyboard, performance, screen, speed in every way it resembles the MPB 2010... hope it's still my main laptop in 2029 or maybe 2030