I upgrade every year.......I have had every iPhone since the first one.
Every 5 Years. I dont need an upgrade when the old device still works fine.
Upgrading now from a 5S to XS Max.
Less often than I use to now that the prices are at the level they are.