My M1 Pro is the best all-round machine I have ever owned from any vendor, including self built high spec machines like the one in my sig. It's a massive step up in every way from previous MacBooks I have owned, it's not even close. Previous Macs for me performed about as well as expected coming from PC portable hardware. The M series just blast that into the weeds.
I do not regret.
There's always something new coming down the pipe. Buy what you need today, budget to plan to upgrade in 3-4 years, push it to 5 or so if it's still good, repeat. Expecting computers to last forever is unrealistic, a lot changes in 3-5 years to render older machines obsolete no matter how high you spec them (new ports, storage standards, wifi standards, etc. baseline cpu/gpu performance improvement, etc.).
I'll upgrade to an M4 or M5 when this one is getting tired, but for now, its still great.
edit:
The only slight regret I have is going for a Pro instead of a Max. I might go for a Max next time depending on how well the Apple gaming scene takes off. Whilst the pro will run games OK, if the macOS gaming platform takes off a bit, and parallels windows virtualisation + x86 emulation keeps getting better, it may be worth going for the max and ditching my gaming PC in the future. Unfortunately one of the PC games I actually play is quite heavy (DCS world) so expecting that to run on a Mac Windows VM is maybe unrealistic. For now.
But if a future Max can help get rid of my gaming PC (and I think by then it might), there's significant budget I'd otherwise be spending on a desktop PC for Mac hardware.