Good points.
#1 My 6P is running great with a sweet 7.1 ROM, and I see ZERO reason to side grade to the Pixel XL. Yes is the Pixel better than the 6P, for sure, of course the hardware is better, and display, etc... but in my opinion, lately the year to year upgrades are not night and day drastically different anymore. Yes better, but will texting be faster ? Will it make phone calls quicker ? Will GPS Navigation work better ? Will it surf the web better ? The answer to all of that is, most likely not. I rather wait for a major upgrade and get the Pixel 2 with the SD835, 6GB RAM, and waterproof.
#2: An iPhone 7 Plus with JB can be a pretty cool phone. Just something different to play with other than Android.
#3: I am shocked at how good old phones still perform today. Two old phones I have sitting at home as back up fun devices; OnePlus One, and HTC One M8, those were both released in 2014, and both are running custom CM14 ROM's, and I am shocked at how smooth and fast they perform. They are buttery smooth, and feel like a top high end phone still. And these phones are two and half years old. Yeah the display and camera tech isn't as great as new phones such as the S7 Edge, but they still run like champs.