I update every three years, bought 8 on day one, so not looking to upgrade until 2020 at minimum. So none of the 2018 phones are of interest.
That said, I would buy an Xr if it were the size of the Xs: not a phablet fan, and until I get to handle an Xr, seems too much like a Plus phone size-wise, which I am not a fan of.
Was not impressed with the X display, meh about Face ID, camera is not important as I use DSLR for shooting and phone camera is for the odd spur of the moment pic (and for that, still darn good camera), add in price tag, not a fan of X other than closer to 6/7/8 sized.
I don't live on my phone, it's a tool in my tech arsenal, so not looking for a TV/laptop/tablet replacement in my phone.