Thank you for this review. You've probably answered a question I was about to post. Will the XR have the text clarity of my current 7+? I had wondered due to the drop in PPI. Your observations seem to suggest it wouldn't. That's a shame, as everything else about the XR makes me want to get one.
I'm pretty sure that the XR will NOT have the text clarity of your 7 Plus. For someone like my wife, she doesn't notice the difference, but someone like you might.
The XR will be very good, but the 7 Plus will still be better, for the very discerning eye, esp. if you favour shorter viewing distances. We shall see though in one month.
But I suffer from presbyopia and a side effect of eye surgery that makes all sharp edges slightly wavy or pixelated. While I don't normally notice it, small text on a small screen makes my eyes tire more quickly, as text is all edges.
Do soft edges on small text make it worse, or small text with sharp edges still cause you problems? Because I'm not sure how that affects the decision in this context. Either way, I'm sorry to hear you have this.
Thanks for the mention of zoom. Can't believe I've had this phone for 2 years and didn't realize it was there. It really helps.
Haha.

I think I showed this feature to my wife 3 years ago, but at that time she preferred the smaller fonts. But then she totally forgot about it. Recently she decided she wanted something bigger, with bigger fonts. I showed her Zoomed Display mode now that's all she uses. I suspect if she had remembered this feature existed, she would have turned it on last year.
In any case, I'm still getting her a larger iPhone, in the form of an XR (which will also have Zoomed Display mode).
So, that leaves the XS or XS Max. Because of the above eye problem, I think I'd have to go to the XS Max for a larger screen area. But do I want to pay more for it than I just did for a 4K touchscreen computer?
You need to go to the XS Max not only because of the larger screen area, but also because the XS does not support Zoomed Display at all AFAIK. (It's not on the X in either iOS 11 or iOS 12, and there are no references to it for the XS in iOS 12 that people could find, so I assume the XS doesn't get it either.) AFAIK, for the 2018 models, only the XS Max and XR support this.
I hear ya on the cost. In Canada, the XS Max 256 GB costs exactly the same as my 12" MacBook Core m3 256 GB.
I just installed IOS 12 on my 7+ and it's acting like a young phone again. Maybe I'll just keep it for another year.
That's what I'm doing. It was a combination of the crazy high price of the XS Max (which is 57% more than the XR in the storage size I want), and the 7 Plus's top-of-the-line pixel density, along with the fact this 7 Plus flies with iOS 12.
Plus the XS/XS Max does NOT fix the camera problem I've been complaining about for 2 years now. In portrait mode (which was introduced with the 7 Plus), often the camera software has problems identifying where the edge of the subject is, vs. the background. So the camera software will blur out the background, but incorrectly, so the edge of the subject gets fuzzy, etc. In The Verge's review, he shows how the XS actually erased part his subject's glasses in portrait mode, which is the exact same behaviour as our 7 Plusses.