Hi everybody!
View attachment 848578
Acceleration achieved on DP4 with two NOPs to SkyLightOriginal: I saw loginwindow crashes, found "assertion failed" messages in DiagnosticReports, and... uh... ummm... patched out the assertions... Hey, it works!
As usual, I'll edit in details in a moment once I get over my excitement.
Edit: Alright, here you go:
There are no new symbols in either SkyLight or CoreDisplay. However, the function
SLSReenableUpdateTokenWithSeed was bombing with "Assertion failed: (wid != 0)" and "Assertion failed: (sid != 0)". So I just NOP'd the places where it jumps to those messages:
This is, of course, incredibly dumb, but one thing that lends
some credence to my solution is that the new function looks mostly unchanged (from a quick skim), but
it does not have those assertions anymore. So, it is possible that a value of zero for those IDs is no longer indicative of a problem. It's also quite possible that I'm just masking the real issue...
If anybody who actually understands assembler wants to take a quick poke around (looking at you,
@pkouame and
@testheit) and confirm or refute my suspicion (and maybe find a better solution), that would be great
Latest wrapped frameworks are attached as always. (The only change since my Dock/login fixes is the SkyLightOriginal modification, but I'll put the full frameworks here for convenience.)
As for changes in DP4, a quick list of things I've seen so far:
- The IOHIDFamily patches don't
seem to be necessary anymore. I'll edit to confirm this after a couple more timeout-free reboots, though.
Edit: seems stable.
@dosdude1 and
@0403979, you may want to update your patchers.
- There are now notifications confirming whether you want to allow an app to notify you (I
think this is new?)
View attachment 848583
Edit: There are also new toggle switches for this in System Preferences:
View attachment 848589
- Apple seemingly followed my lead (as with Xcode!) and fixed the Siri crash by disabling the "flames view" on non-Metal systems:
View attachment 848584
(If you're reading this, thank you Apple engineers!)
- There's an empty "Legacy Desktops" folder in System Preferences. No idea what it does. Maybe it's for those who installed over a previous OS?
View attachment 848585
-
Edit: One more change I've noticed -- last edit, I swear... Our old friend Safari is back in Launchpad! (I'm very happy about this one.)
View attachment 848588
My apologies for the long (as usual) post. Please report back as always! And have a good night